Remove focusout submits the field #16910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
fix/focus-out-submits
branch
from
b30e155 to
2b0e31f
Compare
cbliard
approved these changes
Oct 7, 2024
| @@ -38,7 +38,6 @@ import { EditFieldComponent } from 'core-app/shared/components/fields/edit/edit- | |||
| [attr.lang]="locale" | |||
| [(ngModel)]="value" | |||
| (keydown)="handler.handleUserKeydown($event)" | |||
| (focusout)="handler.onFocusOut()" | |||
oliverguenther
force-pushed
the
fix/focus-out-submits
branch
from
2b0e31f to
334bdf2
Compare
oliverguenther
force-pushed
the
fix/focus-out-submits
branch
from
7cf2654 to
f828c30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/58286
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
The subject would auto submit if you focus out. However, if you edit and open another field, it would result in a race condition between submitting and opening the other field. We can instead simply rely on the user explicitly saving with enter.